Add notes to assertion #1548
Merged
Add notes to assertion #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That would be great step for better testing. 🥇 |
kimdv
force-pushed
the
kimdv/add-notes-to-assertion
branch
from
d698590 to
91d26cb
Compare
kimdv
commented
Apr 15, 2023
kimdv
force-pushed
the
kimdv/add-notes-to-assertion
branch
2 times, most recently
from
60da6f4 to
e349f91
Compare
kimdv
force-pushed
the
kimdv/add-notes-to-assertion
branch
3 times, most recently
from
81a11af to
ba5be84
Compare
|
@ahoppen this is ready for review now 😅 |
kimdv
force-pushed
the
kimdv/add-notes-to-assertion
branch
from
ba5be84 to
9d62ac1
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #1467 as tought that it might also makes sense to force testing for notes.
Let me hear what you think before I continue fixing the other failing 223 test cases @ahoppen