Skip to content

Add notes to assertion #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 14, 2023

As in #1467 as tought that it might also makes sense to force testing for notes.

Let me hear what you think before I continue fixing the other failing 223 test cases @ahoppen

@kimdv kimdv requested a review from ahoppen as a code owner April 14, 2023 22:03
@ahoppen
Copy link
Member

ahoppen commented Apr 14, 2023

That would be great step for better testing. 🥇

@kimdv kimdv force-pushed the kimdv/add-notes-to-assertion branch from d698590 to 91d26cb Compare April 15, 2023 07:54
@kimdv kimdv force-pushed the kimdv/add-notes-to-assertion branch 2 times, most recently from 60da6f4 to e349f91 Compare April 15, 2023 15:14
@kimdv kimdv force-pushed the kimdv/add-notes-to-assertion branch 3 times, most recently from 81a11af to ba5be84 Compare May 2, 2023 19:21
@kimdv
Copy link
Contributor Author

kimdv commented May 2, 2023

@ahoppen this is ready for review now 😅

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏽

@kimdv kimdv force-pushed the kimdv/add-notes-to-assertion branch from ba5be84 to 9d62ac1 Compare May 3, 2023 10:53
@kimdv
Copy link
Contributor Author

kimdv commented May 3, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented May 3, 2023

@swift-ci please test windows

@kimdv kimdv merged commit 36b0f23 into swiftlang:main May 3, 2023
@kimdv kimdv deleted the kimdv/add-notes-to-assertion branch May 3, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants