Skip to content

Fix wrong diagnostic parse typed pattern #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 25, 2023

While digging in #1484 I found this.

@kimdv kimdv requested a review from ahoppen as a code owner April 25, 2023 09:15
@kimdv kimdv force-pushed the kimdv/fix-wrong-diagnostic-for-wrong-pattern branch from bb59f6c to 2ef3fc8 Compare April 25, 2023 09:16
@kimdv kimdv force-pushed the kimdv/fix-wrong-diagnostic-for-wrong-pattern branch from 2ef3fc8 to 40bb7a9 Compare April 25, 2023 20:05
@kimdv
Copy link
Contributor Author

kimdv commented Apr 25, 2023

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/fix-wrong-diagnostic-for-wrong-pattern branch from 40bb7a9 to 655613f Compare April 26, 2023 09:14
@kimdv
Copy link
Contributor Author

kimdv commented Apr 26, 2023

@swift-ci please test

@kimdv kimdv requested a review from ahoppen April 26, 2023 09:16
@kimdv
Copy link
Contributor Author

kimdv commented Apr 26, 2023

@swift-ci please test windows

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That’s much cleaner now

@kimdv kimdv merged commit 8ddbb9a into swiftlang:main Apr 26, 2023
@kimdv kimdv deleted the kimdv/fix-wrong-diagnostic-for-wrong-pattern branch April 26, 2023 15:36
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Apr 26, 2023
kimdv added a commit to kimdv/swift-syntax that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants