[5.9] Add a public function that can be used to test macro expansions #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Apr 25, 2023
ahoppen
changed the title
|
@swift-ci Please test |
DougGregor
approved these changes
Apr 25, 2023
ahoppen
force-pushed
the
ahoppen/5.9/assert-macro
branch
from
4f32783 to
6863ec2
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Testing macros should be as easy as possible and we should thus make the `assertMacroExpansion` function public. While making the function public, I made the following changes: - Changed `diagnosticMessages` to expect `DiagnsoticSpec` similar to the parser tests. The only difference is that they take line and columns instead of location markers because the location markers have a slighgly high learning curve IMO. Slightly unrelated, I also made the following changes: - Made a few minor improvements to `SwiftParserTest/Assertions.swift` - Fixed a bug in MacroApplication where the wrong syntax node was passed as the `node` parameter` to `addDiagnostics`, leading to a highlight that was bigger than expected.
ahoppen
force-pushed
the
ahoppen/5.9/assert-macro
branch
from
6863ec2 to
c7b75dd
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1550 to release/5.9
Testing macros should be as easy as possible and we should thus make the
assertMacroExpansionfunction public.While making the function public, I made the following changes:
diagnosticMessagesto expectDiagnsoticSpecsimilar to the parser tests. The only difference is that they take line and columns instead of location markers because the location markers have a slighgly high learning curve IMO.Slightly unrelated, I also made the following changes:
SwiftParserTest/Assertions.swiftnodeparametertoaddDiagnostics`, leading to a highlight that was bigger than expected.