Skip to content

[5.9] Fix debugInitCall #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 1, 2023

  • Explanation: I broke debugInitCall when I removed the custom mirrors for syntax nodes. Fix it again, also fixing some more issues along the way that previously caused us to generate Swift code that didn’t compile.
  • Scope: A method that is only intended for debugging purposes
  • Risk: Zero, this methods is never called in any production code
  • Testing: Manual
  • Issue: rdar://108756044
  • Reviewer: @bnbarham on Fix debugInitCall #1543

I broke `debugInitCall` when I removed the custom mirrors for syntax nodes. Fix it again, also fixing some more issues along the way that previously caused us to generate Swift code that didn’t compile.
@ahoppen ahoppen requested a review from DougGregor May 1, 2023 21:30
@ahoppen
Copy link
Member Author

ahoppen commented May 1, 2023

@swift-ci Please test

@ahoppen ahoppen changed the title Fix debugInitCall [5.9] Fix debugInitCall May 1, 2023
@ahoppen ahoppen merged commit 27cd619 into swiftlang:release/5.9 May 2, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/fix-debuginitcall branch May 2, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants