Drop Keyword suffix from TokenSpecSet
#1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
kimdv
approved these changes
May 16, 2023
bnbarham
approved these changes
May 16, 2023
| case `do` | ||
| case `fallthrough` | ||
| case `for` | ||
| case forget // NOTE: support for deprecated _forget |
There was a problem hiding this comment.
Yes. Thanks. I missed that
ahoppen
force-pushed
the
ahoppen/drop-keyword-suffix
branch
from
fb41a22 to
0a96021
Compare
|
@swift-ci Please test |
Since we started modelling keywords as a single `RawTokenKind` there hasn’t been an `ifKeyword` etc. anymore. Instead we always refered to them as `Keyword.if` or `.if` everywhere. We should be consistent about this in `TokenSpecSet` as well, which also shouldn’t have a `Keyword` suffix on the cases.
ahoppen
force-pushed
the
ahoppen/drop-keyword-suffix
branch
from
0a96021 to
d3316f9
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started modelling keywords as a single
RawTokenKindthere hasn’t been anifKeywordetc. anymore. Instead we always refered to them asKeyword.ifor.ifeverywhere. We should be consistent about this inTokenSpecSetas well, which also shouldn’t have aKeywordsuffix on the cases.