Skip to content

Add syntax trait covering genericParameterClause and genericWhereClause #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2023
Merged

Add syntax trait covering genericParameterClause and genericWhereClause #1903

merged 2 commits into from
Jul 13, 2023

Conversation

Matejkob
Copy link
Contributor

Resolves #1810

  • Added the WithGenericParameters trait.
  • Sorted the TRAITS collection declarations alphabetically.
  • Included missing documentation for GenericParameterClause and GenericWhereClause types, as well as for all child nodes of the kind genericParameterClause and genericWhereClause.

@Matejkob Matejkob requested a review from ahoppen as a code owner July 13, 2023 07:24
ahoppen
ahoppen reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, also for adding some more documentation and sorting the traits. I’ve got a couple of very minor comments, otherwise looks very good to me.

@Matejkob Matejkob force-pushed the with-generic-parameters-trait branch from 732291f to 5ee3144 Compare July 13, 2023 10:29
ahoppen
ahoppen approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ahoppen
Copy link
Member

ahoppen commented Jul 13, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 13, 2023 10:38
@ahoppen ahoppen disabled auto-merge July 13, 2023 15:30
@ahoppen ahoppen enabled auto-merge July 13, 2023 15:30
@ahoppen
Copy link
Member

ahoppen commented Jul 13, 2023

@swift-ci Please test macOS

@ahoppen ahoppen merged commit 7ed925d into swiftlang:main Jul 13, 2023
@Matejkob Matejkob mentioned this pull request Aug 30, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There should be a syntax trait covering genericParameterClause and genericWhereClause
2 participants
@Matejkob @ahoppen