Skip to content

Add documentation for base types with their subtypes #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add documentation for base types with their subtypes #2232

merged 1 commit into from
Sep 25, 2023
+158 −1

Conversation

divalue
Copy link
Contributor

@divalue divalue commented Sep 23, 2023

Motivation

Changes

  • Adds subtypes documentation to SyntaxBaseNodes

Example:

Screenshot 2023-09-23 at 18 18 51

@kimdv
Copy link
Contributor

kimdv commented Sep 25, 2023

@swift-ci please test

kimdv
kimdv approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@kimdv kimdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @divalue!

And welcome to Swift Syntax 🥳

ahoppen
ahoppen approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤩 Thank you!

@ahoppen ahoppen merged commit 894fc62 into swiftlang:main Sep 25, 2023
@ahoppen ahoppen mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@kimdv kimdv kimdv approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divalue @kimdv @ahoppen