Skip to content

Add incremental parse function that return a new IncrementalParseResult #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add incremental parse function that return a new IncrementalParseResult #2299

wants to merge 1 commit into from

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Oct 17, 2023

Fixes #2267

@kimdv kimdv self-assigned this Oct 17, 2023
kimdv
kimdv commented Oct 17, 2023
View reviewed changes
Sources/SwiftParser/ParseSourceFile.swift
/// ``IncrementalParseTransition`` that contains the previous tree as well
/// as the edits that were performed to it.
/// - Returns: The ``IncrementalParseResult``.
public static func parseIncrementally(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay this will break as is, as the compiler cannot figure out what function to use.

We could, for now, say that it should use @_disfavoredOverload on the new one if we want.

Then people can transition

@kimdv kimdv force-pushed the kimdv/2267-change-parseincrementally-to-return-a-struct-instead-of-a-tuple branch from 5d31a4c to 388a9da Compare October 17, 2023 18:04
@ahoppen
Copy link
Member

ahoppen commented Oct 17, 2023

@divalue is already working on this here: #2299

@ahoppen ahoppen closed this Oct 17, 2023
@kimdv kimdv deleted the kimdv/2267-change-parseincrementally-to-return-a-struct-instead-of-a-tuple branch October 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees

@kimdv kimdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change parseIncrementally to return a struct instead of a tuple
2 participants
@kimdv @ahoppen