Add a command to dev utils that run all other necessary scripts to submit a PR #2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matejkob
commented
Nov 7, 2023
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
Matejkob
commented
Nov 7, 2023
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
ahoppen
reviewed
Nov 7, 2023
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/IntegrityCheck.swift
Outdated
Show resolved
Hide resolved
Matejkob
force-pushed
the
one-to-rule-them-all
branch
from
b1941ab to
bbb7113
Compare
Matejkob
force-pushed
the
one-to-rule-them-all
branch
from
bbb7113 to
17d07c8
Compare
ahoppen
reviewed
Nov 28, 2023
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/LocalPrPrecheck.swift
Outdated
Show resolved
Hide resolved
Matejkob
force-pushed
the
one-to-rule-them-all
branch
from
17d07c8 to
13236e1
Compare
ahoppen
approved these changes
Nov 29, 2023
|
@swift-ci Please test |
kimdv
approved these changes
Nov 30, 2023
Matejkob
force-pushed
the
one-to-rule-them-all
branch
from
13236e1 to
8759911
Compare
Add the script to the swift-syntax dev utils package to allow developers run all necessary actions before submitting a PR
Matejkob
force-pushed
the
one-to-rule-them-all
branch
from
8759911 to
16294a2
Compare
Matejkob
force-pushed
the
one-to-rule-them-all
branch
from
16294a2 to
74d0e6f
Compare
Matejkob
commented
Jan 25, 2024
| ) | ||
|
|
||
| @OptionGroup | ||
| var arguments: SourceCodeGeneratorArguments |
There was a problem hiding this comment.
@ahoppen I've used this arguments group because it has all the needed arguments for this command but the name doesn't fit anymore, should I change it or stop using it and create local arguments?
There was a problem hiding this comment.
If you have any good new name ideas for SourceCodeGeneratorArguments. If you have any, I think renaming would be nice but otherwise, I think it’s OK as-is as well.
ahoppen
approved these changes
Jan 26, 2024
| ) | ||
|
|
||
| @OptionGroup | ||
| var arguments: SourceCodeGeneratorArguments |
There was a problem hiding this comment.
If you have any good new name ideas for SourceCodeGeneratorArguments. If you have any, I think renaming would be nice but otherwise, I think it’s OK as-is as well.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the script to the swift-syntax dev utils package to allow developers to run all necessary actions before submitting a PR
Resolves #2066