Add "Opening a PR for Release Branch" section to contributing document #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matejkob
force-pushed
the
release-pr-template
branch
4 times, most recently
from
03d4b8b to
72eb440
Compare
Matejkob
force-pushed
the
release-pr-template
branch
from
72eb440 to
dc5e2b7
Compare
Matejkob
commented
Apr 20, 2024
There was a problem hiding this comment.
Right now since Github does not offer users UI for choosing a pull request template this is not very useful because one has to manually edit the URL during the process of creating the PR. Although, I believe it would not harm to have this template in the repo.
There was a problem hiding this comment.
Oh, nice. I didn’t know about the ability to specify a custom template. I have a script locally that hard-codes the template into the URL parameters 😉
ahoppen
approved these changes
Apr 22, 2024
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new "Opening a PR for Release Branch" section to the
CONTRIBUTING.mddocument, providing clear instructions and requirements for opening pull requests targeting release branches.It also adds a new pull request template specifically for release branch PRs. However, due to current limitations of GitHub's UI, the template's usability is somewhat limited, as users need to manually modify the URL during the PR creation process to select the template.