-
Notifications
You must be signed in to change notification settings - Fork 440
Add support for WebAssembly Macros #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
158ddd5
Rebase
kabiroberai 385cc0a
Merge branch 'main' into kabir/wasm-plugins
kabiroberai 4dd83b3
cleanup
kabiroberai 0b6a5a6
We don’t need internalError
kabiroberai 7a6b576
Comment
kabiroberai f5d82ef
Feedback
kabiroberai 9f455cb
More feedback
kabiroberai 18814f1
comment
kabiroberai a38baa4
comment
kabiroberai a582c2f
Merge branch 'main' into kabir/wasm-plugins
kabiroberai 85e0374
Change wasm versioning approach
kabiroberai 921b7ea
Merge branch 'main' into kabir/wasm-plugins
kabiroberai 9fab7cc
Merge branch 'main' into kabir/wasm-plugins
kabiroberai d3495f2
Create PluginMessageHandler
kabiroberai 76de84f
Make PluginMessage.Diagnostic.init SPI
kabiroberai 76f7d8f
Use _expose
kabiroberai 3e2e4d4
Merge branch 'main' into kabir/wasm-plugins
kabiroberai cf060a4
Feedback
kabiroberai 4cd128c
Fix calling convention
kabiroberai 84f3230
Update .spi.yml
kabiroberai 2242b64
Format
kabiroberai 054e5e3
Merge branch 'main' into kabir/wasm-plugins
kabiroberai 595b0ae
re-format
kabiroberai c7466de
Merge branch 'main' into kabir/wasm-plugins
kabiroberai 0a054ad
Merge branch 'main' into kabir/wasm-plugins
kabiroberai 0e65034
Fix swiftlang/swift build
kabiroberai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this abstraction is needed anyway, so this is okay. But TBH, I'm not a fan of
WasmInterceptingMessageHandler
in swiftlang/swift#73031.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm not the biggest fan either :/ but that's the only approach I could think of which allows us to send some messages from
swift-plugin-server
toLibraryPluginProvider
while intercepting others. The alternative is to have an entirely separateswift-wasm-plugin-server
(so that the primary plugin server can useLibraryPluginProvider
directly) but both Doug and Yuta feel that having a unified plugin server is preferable (see swiftlang/swift#73031 (comment)), and I agree that the benefits outweigh the downsides atm.Curious to hear if you have any alternative suggestions though.