[Macros] Cache parsed syntax tree in compiler plugins #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
reviewed
Jun 12, 2024
| /// Syntax added by `add(_:)` method. Keyed by the `id` of the node. | ||
| private var knownSourceSyntax: [Syntax.ID: KnownSourceSyntax] = [:] | ||
|
|
||
| init(syntaxrRegistry: ParsedSyntaxRegistry) { |
There was a problem hiding this comment.
Suggested change
| init(syntaxrRegistry: ParsedSyntaxRegistry) { | |
| init(syntaxRegistry: ParsedSyntaxRegistry) { |
The compiler may send the same syntax to the plugins multiple times. For example, 'memberAttribute' macro request contains parent nominal decl syntax, and the compiler sends a request for each members. Parsing it multiple times is a waste. rdar://129624305
rintaro
force-pushed
the
macros-parsed-syntax-registry
branch
from
d0eb2f7 to
3c23a0e
Compare
|
@swift-ci Please test |
rintaro
force-pushed
the
macros-parsed-syntax-registry
branch
from
3c23a0e to
baff373
Compare
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 13, 2024
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
rintaro
added a commit
that referenced
this pull request
Jun 15, 2024
[6.0][Macros] Cache parsed syntax tree in compiler plugins #2682
ahoppen
reviewed
Jun 17, 2024
| @@ -24,6 +24,49 @@ import SwiftSyntax | |||
| import SwiftSyntaxMacros | |||
| #endif | |||
|
|
|||
| /// Caching parser for PluginMessage.Syntax | |||
| class ParsedSyntaxRegistry { | |||
There was a problem hiding this comment.
Naming nitpick: A registry for me is something that stores long-lived values (possibly even eternal), which is quite the opposite of a cache. Would ParsedSyntaxCache be a better name?
There was a problem hiding this comment.
Heh, in fairness it was originally the first. The LRU was added after 😅. But yeah, Cache is probably the better name now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler may send the same syntax to the plugins multiple times.
For example,
memberAttributemacro request contains parent nominal decl syntax, and the compiler sends a request for each members. Parsing it multiple times is a waste.rdar://129624305