-
Notifications
You must be signed in to change notification settings - Fork 439
[SwiftLexicalLookup][GSoC] New lookup method signature and Identifier
initializer changes
#2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SwiftLexicalLookup][GSoC] New lookup method signature and Identifier
initializer changes
#2789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my review comments. I think the following comments from #2748 are still open.
- [SwiftLexicalLookup][GSoC] Add proper guard scope and implicit name lookup #2748 (comment)
- [SwiftLexicalLookup][GSoC] Add proper guard scope and implicit name lookup #2748 (comment)
- [SwiftLexicalLookup][GSoC] Add proper guard scope and implicit name lookup #2748 (comment)
- [SwiftLexicalLookup][GSoC] Add proper guard scope and implicit name lookup #2748 (comment)
|
Thanks 👍🏽
OK, just wanted to make sure we are aware of it and don’t carry around old cruft just because nobody knows what it might be used for 👍🏽
Oh sorry, I missed that test case. Looks good.
That’s a good step. I still think that it’s worth exploring to unify the |
@swift-ci Please test |
This PR includes changes suggested by @ahoppen under #2748 that didn't make it before merging.