Improve unexpected tokens diagnostics

[mateusrodriguesxyz]

While investigating #1373 I noticed that replacing a break with a continue in canRecoverTo improves diagnostic in a number of recovery tests.
I've also added a little logic to call skipSingle so we achieve desired diagnostic in testRecovery105(), but only if possible at the same line, so cases like testRecovery100() is not messed up.

[ahoppen]

Looks great. Thank you @mateusrodriguesxyz!

[ahoppen]

@swift-ci Please test

[mateusrodriguesxyz]

Couldn't figure out what caused the tests to fail 🤔

[ahoppen]

Looks like BasicFormatTest.testClosureParameter failed. That test did look unrelated to your other changes anyway.

/Users/ec2-user/jenkins/workspace/swift-syntax-PR-macOS/branch-main/swift-syntax/Tests/SwiftBasicFormatTest/BasicFormatTests.swift:62: error: -[SwiftBasicFormatTest.BasicFormatTest testClosureParameter] : failed - Actual output does not match the expected
 myFunc({
     return true
–})
+    })

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

Looks like a few files that used to parse correctly now no longer do.

Failed Tests (9):
  Swift(macosx-x86_64) :: ModuleInterface/features.swift
  Swift(macosx-x86_64) :: Parse/ConditionalCompilation/compiler.swift
  Swift(macosx-x86_64) :: Parse/ConditionalCompilation/language_version_explicit.swift
  Swift(macosx-x86_64) :: Parse/ConditionalCompilation/sequence_version.swift
  Swift(macosx-x86_64) :: Parse/features.swift
  Swift(macosx-x86_64) :: SILGen/specialize_attr.swift
  Swift(macosx-x86_64) :: SILOptimizer/pre_specialize-macos.swift
  Swift(macosx-x86_64) :: SILOptimizer/pre_specialize.swift
  Swift(macosx-x86_64) :: SILOptimizer/pre_specialize_layouts.swift

These files are located in https://github.com/swiftlang/swift/tree/main/test

[ahoppen]

Oh, looks like the errors are unrelated to your PR, they also seem to fail in #2814.

[mateusrodriguesxyz]

These failed in #2814 too.

[DougGregor]

I think swiftlang/swift#76040 will fix this issue

[mateusrodriguesxyz]

@ahoppen I think this should pass now that swiftlang/swift#76040 has been merged. Could you test again, please?

[DougGregor]

@swift-ci please test

[mateusrodriguesxyz]

Thanks @DougGregor !