Skip to content

[CMake] Disable SWIFTSYNTAX_EMIT_MODULE by default #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 2, 2024

SWIFTSYNTAX_EMIT_MODULE flag is for compiling swift-syntax with library evolution enabled. But that is only useful for limited use cases. When using swift-syntax just as a CMake dependencies, not-enabling library evolution is probably the desired behavior.

`SWIFTSYNTAX_EMIT_MODULE` flag is for compiling swift-syntax with
library evolution enabled. But that is only useful for limited use
cases. When using swift-syntax just as a CMake dependencies,
not-enabling library evolution is probably the desired behavior.
@rintaro
Copy link
Member Author

rintaro commented Oct 2, 2024

swiftlang/swift#76838
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Oct 3, 2024

swiftlang/swift#76851
@swift-ci Please test macOS

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Oct 3, 2024

swiftlang/swift#76851
@swift-ci Please test macOS

@rintaro
Copy link
Member Author

rintaro commented Oct 3, 2024

swiftlang/swift#76851
@swift-ci Please test macOS

@rintaro rintaro enabled auto-merge October 3, 2024 22:03
@rintaro
Copy link
Member Author

rintaro commented Oct 3, 2024

@swift-ci Please test macOS

@rintaro rintaro merged commit e62869b into swiftlang:main Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants