[Syntax] Add init(unsafeCasting: Syntax)
to concrete node types
#2924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init(unsafeCasting:)
should only be used when we are absolutely sure the syntax kind matches the type, and only in perf critial places. Use it inSyntaxEnum
,SyntaxVisitor
, andSyntaxRewriter
.Also, rework
SyntaxVisitor
/SyntaxRewriter
visitation, eliminating unnecessary ARC traffic.Baseline:
With this patch:
This patch eliminates ARC during visitation funcs, but we still need to retain the parent
Syntax.Info
when constructingSyntax
.