Skip to content

[6.0.2] Fix WASI build with CMake #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Sep 12, 2024

When building the Testing library as a static library
(BUILD_SHARED_LIBS=FALSE), `_TestingInternals` was not being installed
alongside the main library. This caused the missing symbol error when
linking against the Testing library statically.
This is a follow-up fix to f078f7a that I made at the last
minute before merging...
@grynspan grynspan added wasi/wasm 🧭 WebAssembly support build 🧱 Affects the project's build configuration or process labels Sep 12, 2024
@grynspan grynspan added this to the Swift 6.0.1 milestone Sep 12, 2024
@shahmishal shahmishal changed the base branch from release/6.0.1 to release/6.0.2 September 20, 2024 05:22
@shahmishal shahmishal changed the title [6.0.1] Fix WASI build with CMake [6.0.2] Fix WASI build with CMake Sep 20, 2024
@shahmishal
Copy link
Member

I updated the targeted branch to release/6.0.2 from release/6.0.1.

@grynspan grynspan merged commit 981ef15 into swiftlang:release/6.0.2 Sep 24, 2024
@kateinoigakukun kateinoigakukun deleted the yt/pick-wasi-cmake-build branch September 24, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🧱 Affects the project's build configuration or process wasi/wasm 🧭 WebAssembly support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants