Skip to content

Disable pipes code on WASI. #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Disable pipes code on WASI. #699

merged 2 commits into from
Sep 17, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 17, 2024

WASI does not support pipes.

Resolves #698.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

WASI does not support pipes.

Resolves #698.
@grynspan grynspan added bug 🪲 Something isn't working wasi/wasm 🧭 WebAssembly support labels Sep 17, 2024
@grynspan grynspan self-assigned this Sep 17, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@kateinoigakukun Please assist testing this PR. Thanks!

@grynspan
Copy link
Contributor Author

@swift-ci test

@kateinoigakukun
Copy link
Member

I verified it builds well on WASI, thanks for your quick fix!

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit 9693475 into main Sep 17, 2024
0 of 3 checks passed
@grynspan grynspan deleted the jgrynspan/698-wasi-no-pipes branch September 17, 2024 03:40
@grynspan
Copy link
Contributor Author

Thaaaat wasn't the auto-merge button.

Oh well.

grynspan added a commit that referenced this pull request Sep 17, 2024
WASI does not support pipes.

Resolves #698.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added this to the Swift 6.1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working wasi/wasm 🧭 WebAssembly support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditionalize pipe(2) usage for WASI
2 participants