-
Notifications
You must be signed in to change notification settings - Fork 108
Add a document about porting to new platforms. #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR adds a new Porting.md file including information for developers who want to port Swift Testing to new platforms. The document uses Classic Mac OS as a strawman/example platform. That was fun. Shoutout to @belkadan. It also adds a `SWT_NO_TIMESPEC` conditional because I realized that there are platforms that don't have C11's `struct timespec`. (Because Classic Mac OS should obviously have C types standardized 2011.) Formatted version [here]().
@swift-ci test |
@swift-ci test |
@swift-ci test |
> must build and (minimally) function before you will be able to successfully | ||
> build Swift Testing regardless of which platform you are porting to. | ||
|
||
### Swift or C++? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps reorder this section later in the document? Reading through it as a step-by-step, this paragraph feels a little bit out of place. What changes would I even be making, where the choice of programming language is applicable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading along, I want to know "you should be using Swift" before I get into the technical details, I think? It would read oddly to be two sections in and see "oh by the way don't use C++ unless you absolutely have to." I've already started writing code by then!
I think.
I dunno. Where do you want to move it to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this as-is, but we can revise.
This PR adds a new Porting.md file including information for developers who want to port Swift Testing to new platforms. The document uses Classic Mac OS as a strawman/example platform. That was fun. Shoutout to @belkadan.
It also adds a
SWT_NO_TIMESPEC
conditional because I realized that there are platforms that don't have C11'sstruct timespec
. (Because Classic Mac OS should obviously have C types standardized 2011.)Formatted version here.
Checklist: