[6.0.0][CMake] Explicitly link Testing to Foundation #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#641) **Explanation:** Sets the version of the library as built in CMake to "6.0". **Scope:** 6.0 releases built with CMake instead of SwiftPM **Issue:** N/A **Original PR:** swiftlang#637, swiftlang#638 **Risk:** Low **Testing:** Manually tested at desk and in a toolchain build as we don't have CI jobs using CMake yet. See swiftlang/swift#76034 **Reviewer:** @compnerd @briancroom
…tead of a C++ macro. (swiftlang#650) **Explanation:** Correctly sets the testing library version (it was failing to set on the Swift side.) **Scope:** Building with CMake **Issue:** N/A **Original PR:** swiftlang#648 **Risk:** Low **Testing:** Built a toolchain and verified the string was ingested all the way through. **Reviewer:** @grynspan @briancroom
(cherry picked from commit 79a443a)
WASI doesn't support `libdispatch` (cherry picked from commit c2f8ccc)
rintaro
requested review from
stmontgomery,
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #693 into
release/6.0.0Foundationwas not in the regular search directory (e.g. resource directory or SDK search paths)#if canImport(Foundation)used to fail, and the functionalities are not included. This patch provides a way to provideFoundation_DIRforfind_packgage(Foundation CONFIG), so that clients can correctly link Testing to Foundation