Avoid using String while holding an internal libobjc lock.
#938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`String` can inadvertently touch libobjc when we implicitly cast it to a C string (when calling `getsectiondata()`), which can result in a deadlock if that operation needs to acquire one of libobjc's internal locks. Switch to `StaticString` which we can guarantee never touches libobjc. Resolves rdar://144093524.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
briancroom
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stringcan inadvertently touch libobjc when we implicitly cast it to a C string (when callinggetsectiondata()), which can result in a deadlock if that operation needs to acquire one of libobjc's internal locks.Switch to
StaticStringwhich we can guarantee never touches libobjc.Resolves rdar://144093524.
Checklist: