[5.5] Propagate method async-ness during test discovery
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sync with main to pick up the Swift async symbol property definition. * Extend `IndexStore.TestCaseClass` to include information about `async` test methods. * Model as a struct instead of enum for easier future expansion. * Take isAsync into account when comparing. * Tweak argument name for clarity.
briancroom
requested review from
stmontgomery,
neonichu,
tomerd,
SeanROlszewski and
grynspan
briancroom
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
Note that these changes will not be effective without several additional supporting changes in other repos also being pulled back to release/5.5, including: |
|
@swift-ci please test |
tomerd
approved these changes
Nov 11, 2021
stmontgomery
approved these changes
Nov 11, 2021
|
This change is safe to land decoupled from the various other PRs involved in the effort, so I'm proceeding to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nominating the changes from #258 to be pulled back for a 5.5.x dot release