Skip to content

Commit 346b13d

Browse files
committed
[android][test] Fix several tests on the Android CI
- #58975 switched many tests from XFAIL on linux to linux-gnu, so seven fail on the Android CI. They are now explicitly excluded. - #42478 removed the @NoEscape attribute for the non-Android SIL/clang-function-types tests, so I remove it for Android too. - My pull #40779 moved the Swift pointer tags to the second byte, so SILOptimizer/concat_string_literals.64 will need to be updated for that, disabled it for now. - Compiler-rt moved the directory in which it places those libraries for Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
1 parent aff121b commit 346b13d

12 files changed

+18
-17
lines changed

test/Driver/Dependencies/only-skip-once.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// XFAIL: OS=linux-gnu, OS=openbsd, OS=windows-msvc
1+
// XFAIL: OS=linux-gnu, OS=openbsd, OS=windows-msvc, OS=linux-android, OS=linux-androideabi
22

33
// RUN: %empty-directory(%t)
44
// RUN: cp -r %S/Inputs/only-skip-once/* %t

test/Driver/parseable_output.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// RUN: %swiftc_driver_plain -emit-executable %s -o %t.out -emit-module -emit-module-path %t.swiftmodule -emit-objc-header-path %t.h -serialize-diagnostics -emit-dependencies -parseable-output -driver-skip-execution 2>&1 | %FileCheck %s
22

3-
// XFAIL: OS=freebsd, OS=openbsd, OS=linux-gnu
3+
// XFAIL: OS=freebsd, OS=openbsd, OS=linux-gnu, OS=linux-android, OS=linux-androideabi
44

55
// CHECK: {{[1-9][0-9]*}}
66
// CHECK-NEXT: {

test/Driver/parseable_output_unicode.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// RUN: cat "%S/Inputs/unicode.txt" >> %t.rsp
33
// RUN: %swiftc_driver_plain -emit-executable @%t.rsp -o %t.out -emit-module -emit-module-path %t.swiftmodule -emit-objc-header-path %t.h -serialize-diagnostics -emit-dependencies -parseable-output -driver-skip-execution 2>&1 | %FileCheck %s
44

5-
// XFAIL: OS=freebsd, OS=openbsd, OS=linux-gnu
5+
// XFAIL: OS=freebsd, OS=openbsd, OS=linux-gnu, OS=linux-android, OS=linux-androideabi
66

77
// CHECK: {{[1-9][0-9]*}}
88
// CHECK-NEXT: {

test/Driver/sdk-apple.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// XFAIL: OS=freebsd, OS=openbsd, OS=linux-gnu, OS=windows-msvc
1+
// XFAIL: OS=freebsd, OS=openbsd, OS=linux-gnu, OS=windows-msvc, OS=linux-android, OS=linux-androideabi
22

33
// Test SDK detection for immediate mode.
44
// RUN: %empty-directory(%t)

test/IDE/print_clang_header_i386.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// REQUIRES: OS=macosx
22
// REQUIRES: CPU=x86_64
33
// FIXME: rdar://problem/19648117 Needs splitting objc parts out
4-
// XFAIL: OS=linux-gnu, OS=freebsd
54

65
// RUN: echo '#include "header-to-print.h"' > %t.i386.m
76
// RUN: %empty-directory(%t)

test/IRGen/abitypes.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -I %S/Inputs/abi %s -emit-ir -enable-objc-interop | %FileCheck -check-prefix=%target-cpu-%target-os-abi %s
22

33
// FIXME: rdar://problem/19648117 Needs splitting objc parts out
4-
// XFAIL: OS=linux-gnu, OS=windows-msvc, OS=openbsd
4+
// XFAIL: OS=linux-gnu, OS=windows-msvc, OS=openbsd, OS=linux-android, OS=linux-androideabi
55

66
import gadget
77
import Foundation

test/Reflection/box_descriptors.sil

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// RUN: %target-swift-reflection-dump -binary-filename %t/capture_descriptors%{target-shared-library-suffix} | %FileCheck %s
44

55
// SR-10758
6-
// UNSUPPORTED: OS=linux-gnu
6+
// UNSUPPORTED: OS=linux-gnu, OS=linux-android, OS=linux-androideabi
77

88
// SR-12893
99
// XFAIL: OS=openbsd

test/SIL/clang-function-types-android.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import ctypes
66

77
public func f(g: @convention(c, cType: "void (*)(size_t)") (Int) -> ()) { g(0) }
88

9-
// CHECK-32: sil @$s4main1f1gyySiXzC9_ZTSPFvjE_tF : $@convention(thin) (@convention(c, cType: "void (*)(unsigned int)") @noescape (Int) -> ()) -> () {
10-
// CHECK-32: bb0(%0 : $@convention(c, cType: "void (*)(unsigned int)") @noescape (Int) -> ()):
11-
// CHECK-32: debug_value %0 : $@convention(c, cType: "void (*)(unsigned int)") @noescape (Int) -> (), let, name "g", argno 1 // id: %1
9+
// CHECK-32: sil @$s4main1f1gyySiXzC9_ZTSPFvjE_tF : $@convention(thin) (@convention(c, cType: "void (*)(unsigned int)") (Int) -> ()) -> () {
10+
// CHECK-32: bb0(%0 : $@convention(c, cType: "void (*)(unsigned int)") (Int) -> ()):
11+
// CHECK-32: debug_value %0 : $@convention(c, cType: "void (*)(unsigned int)") (Int) -> (), let, name "g", argno 1 // id: %1
1212

13-
// CHECK-64: sil @$s4main1f1gyySiXzC9_ZTSPFvmE_tF : $@convention(thin) (@convention(c, cType: "void (*)(unsigned long)") @noescape (Int) -> ()) -> () {
14-
// CHECK-64: bb0(%0 : $@convention(c, cType: "void (*)(unsigned long)") @noescape (Int) -> ()):
15-
// CHECK-64: debug_value %0 : $@convention(c, cType: "void (*)(unsigned long)") @noescape (Int) -> (), let, name "g", argno 1 // id: %1
13+
// CHECK-64: sil @$s4main1f1gyySiXzC9_ZTSPFvmE_tF : $@convention(thin) (@convention(c, cType: "void (*)(unsigned long)") (Int) -> ()) -> () {
14+
// CHECK-64: bb0(%0 : $@convention(c, cType: "void (*)(unsigned long)") (Int) -> ()):
15+
// CHECK-64: debug_value %0 : $@convention(c, cType: "void (*)(unsigned long)") (Int) -> (), let, name "g", argno 1 // id: %1

test/SILOptimizer/concat_string_literals.64.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// We have a separate test for 32-bit architectures.
66
// REQUIRES: PTRSIZE=64
77

8+
// The string tag was recently shifted to the second byte on Android AArch64,
9+
// so these tests will need to be adapted for that.
10+
// XFAIL: OS=linux-android && CPU=aarch64
11+
812
// NOTE: 25185.byteSwapped = 0x62 'a', 0x61 'b'
913
// CHECK-LABEL: test_ascii_scalar_scalar2
1014
// CHECK: ret { i64, %swift.bridge* } { i64 25185, %swift.bridge* inttoptr (i64 -{{[0-9]+}} to %swift.bridge*) }

test/Sanitizers/tsan/objc_async.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
// REQUIRES: concurrency
88
// REQUIRES: objc_interop
99
// REQUIRES: tsan_runtime
10-
// UNSUPPORTED: OS=linux-gnu
11-
// UNSUPPORTED: OS=windows-msvc
1210

1311
// rdar://76038845
1412
// UNSUPPORTED: use_os_stdlib

test/lit.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1966,7 +1966,7 @@ def source_compiler_rt_libs(path):
19661966
and config.compiler_rt_platform in lib])
19671967

19681968
compiler_rt_dir = make_path(test_resource_dir, 'clang', 'lib',
1969-
platform.system().lower() if not kIsAndroid else 'android')
1969+
platform.system().lower())
19701970
source_compiler_rt_libs(compiler_rt_dir)
19711971

19721972
def check_runtime_libs(features_to_check):

test/stdlib/simd_diagnostics.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// RUN: %target-typecheck-verify-swift
22

33
// FIXME: No simd module on linux rdar://problem/20795411
4-
// XFAIL: OS=linux-gnu, OS=windows-msvc, OS=openbsd
4+
// XFAIL: OS=linux-gnu, OS=windows-msvc, OS=openbsd, OS=linux-android, OS=linux-androideabi
55
// XFAIL: OS=wasi
66

77
import simd

0 commit comments

Comments
 (0)