Skip to content

[DebugInfo] Ignore noescape bit for all @convention(c) pointers #42478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

asl
Copy link
Contributor

@asl asl commented Apr 20, 2022

This reapplies #42189 with additional windows-only fix

@asl
Copy link
Contributor Author

asl commented Apr 20, 2022

Tagging @jckarter @compnerd

@compnerd
Copy link
Member

@swift-ci please test

@jckarter jckarter merged commit 270d100 into swiftlang:main Apr 20, 2022
@asl asl deleted the escape-c-pointer branch April 20, 2022 20:11
aschwaighofer pushed a commit to aschwaighofer/swift that referenced this pull request May 13, 2022
[DebugInfo] Ignore noescape bit for all @convention(c) pointers

Cherry-pick from swiftlang#42478

rdar://93175432
aschwaighofer added a commit that referenced this pull request May 14, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…t_for_thin_functions_5.7

[5.7] Cherry-pick pull request #42478 [DebugInfo] Ignore noescape bit for all @convention(c) pointers
finagolfin added a commit to finagolfin/swift that referenced this pull request Jun 6, 2022
- swiftlang#58975 switched many tests from XFAIL on linux to linux-gnu, so seven
  fail on the Android CI. They are now explicitly excluded.
- swiftlang#42478 removed the @NoEscape attribute for the non-Android
  SIL/clang-function-types tests, so I remove it for Android too.
- My pull swiftlang#40779 moved the Swift pointer tags to the second byte, so
  SILOptimizer/concat_string_literals.64 will need to be updated for that,
  disabled it for now.
- Compiler-rt moved the directory in which it places those libraries for
  Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
finagolfin added a commit to finagolfin/swift that referenced this pull request Jun 7, 2022
- swiftlang#58975 switched many tests from XFAIL on linux to linux-gnu, so seven
  fail on the Android CI. They are now explicitly excluded.
- swiftlang#42478 removed the @NoEscape attribute for the non-Android
  SIL/clang-function-types tests, so I remove it for Android too.
- My pull swiftlang#40779 moved the Swift pointer tags to the second byte, so
  SILOptimizer/concat_string_literals.64 will need to be updated for that,
  disabled it for now.
- Compiler-rt moved the directory in which it places those libraries for
  Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
finagolfin added a commit to finagolfin/swift that referenced this pull request Jun 9, 2022
- swiftlang#58975 switched many tests from XFAIL on linux to linux-gnu, so seven
  fail on the Android CI and two natively. They are now explicitly excluded.
- swiftlang#39605 added several C++ Interop tests, 11 of which fail on the Android CI,
  so disable them for now.
- swiftlang#42478 removed the @NoEscape attribute for the non-Android
  SIL/clang-function-types tests, so I remove it for Android too.
- My pull swiftlang#40779 moved the Swift pointer tags to the second byte, so
  SILOptimizer/concat_string_literals.64 will need to be updated for that,
  disabled it for now.
- Compiler-rt moved the directory in which it places those libraries for
  Android, llvm/llvm-project@a68ccba, so lit.cfg is updated for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants