Skip to content

[Collect Data] Windows pull request failure unrelated to the changes #63596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shahmishal opened this issue Feb 11, 2023 · 8 comments
Closed
Assignees

Comments

@shahmishal
Copy link
Member

This issue will be used to collect information about the Windows platform testing. Please add the information here if you see any failures on your pull request unrelated to the changes.

@shahmishal shahmishal self-assigned this Feb 11, 2023
@Rajveer100
Copy link
Contributor

Well, in my recent PR #63567 the smoke-tests passed for macOS and Linux platform, while failing for the windows platform, maybe this info might be helpful!

@shahmishal
Copy link
Member Author

Well, in my recent PR #63567 the smoke-tests passed for macOS and Linux platform, while failing for the windows platform, maybe this info might be helpful!

Thanks @Rajveer100

Failed Tests (10):
  Swift(windows-x86_64) :: DebugInfo/alloc_stack_arg.swift
  Swift(windows-x86_64) :: DebugInfo/archetype.swift
  Swift(windows-x86_64) :: DebugInfo/inlined-generics.swift
  Swift(windows-x86_64) :: IRGen/closure.swift
  Swift(windows-x86_64) :: IRGen/generic_tuples.swift
  Swift(windows-x86_64) :: IRGen/opaque_result_type_debug.swift
  Swift(windows-x86_64) :: IRGen/struct_resilience.swift
  Swift(windows-x86_64) :: IRGen/synthesized_conformance.swift
  Swift(windows-x86_64) :: SILGen/protocol_with_superclass.swift
  Swift(windows-x86_64) :: SILGen/protocol_with_superclass_where_clause.swift

cc: @compnerd

@Rajveer100
Copy link
Contributor

#63574

@shahmishal
Copy link
Member Author

#63574

Test failures:

Failed Tests (4):
  Swift(windows-x86_64) :: DebugInfo/dynamic_layout.swift
  Swift(windows-x86_64) :: IRGen/big_types_corner_cases.swift
  Swift(windows-x86_64) :: IRGen/closure.swift
  Swift(windows-x86_64) :: SILGen/vtable_thunks_reabstraction.swift

@shahmishal
Copy link
Member Author

@compnerd has a fix for the memory issue - #63635

@compnerd
Copy link
Member

The original PR that introduced it actually did fail on Windows, we would've caught it then.

@ktoso
Copy link
Contributor

ktoso commented May 25, 2023

This isn't about windows but about two PRs "racing" and thus ending up with broken main:

CI tested those independently and both passed.

Once they got merged into main, the changed diagnostic from (2) caused the new test in (1) to fail on a typo.

This was resolved in: #66138

Technically merge queues prevent such issues, but would add even more potential wait time to merge changes.

Some "middle ground" would be amazing to find but I don't think something automated exists for this yet.

@shahmishal
Copy link
Member Author

This can be closed now. The swift repo now requires Windows testing before merging PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants