-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Collect Data] Windows pull request failure unrelated to the changes #63596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Well, in my recent PR #63567 the smoke-tests passed for macOS and Linux platform, while failing for the windows platform, maybe this info might be helpful! |
Thanks @Rajveer100
cc: @compnerd |
Test failures:
|
The original PR that introduced it actually did fail on Windows, we would've caught it then. |
This isn't about windows but about two PRs "racing" and thus ending up with broken main:
CI tested those independently and both passed. Once they got merged into main, the changed diagnostic from (2) caused the new test in (1) to fail on a typo. This was resolved in: #66138 Technically merge queues prevent such issues, but would add even more potential wait time to merge changes. Some "middle ground" would be amazing to find but I don't think something automated exists for this yet. |
This can be closed now. The swift repo now requires Windows testing before merging PR. |
This issue will be used to collect information about the Windows platform testing. Please add the information here if you see any failures on your pull request unrelated to the changes.
The text was updated successfully, but these errors were encountered: