Changed 'protocols' to 'type constraints' for obsoleted protocol composition syntax error #63574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajveer100
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
…osition syntax error Fixes swiftlang#62518
Rajveer100
force-pushed
the
branch-for-issue-62518
branch
from
819331e to
8e4fd23
Compare
|
Hi, can anyone review this PR? |
|
@swift-ci smoke test |
|
Hey nice to meet you Robert, thanks for the approve! |
|
Definitely there's an issue with the windows smoke test. @shahmishal Another PR with the issue you mentioned! |
AnthonyLatsis
added
improvement
parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62518
Improves the error message caused due to obsoleted protocol composition syntax as discussed in the issue thread,
'type constraints'would be more accurate as it isn't just limited to'protocols'. Changes were done in theinclude/swift/AST/DiagnosticsParse.deffile and the responsible test files in the/testdirectory.