[stdlib] Eliminate the last direct use of Builtin.UnknownObject #11984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the Swift level, this is equivalent to AnyObject, which we've done much more testing of. This commit paves the way for taking UnknownObject out of the SIL type system and just using it as type metadata. Filed https://bugs.swift.org/browse/SR-5926 to track that work.
|
@swift-ci Please test |
|
and just in case, though it would be astonishing for this not to compile down to the same thing… @swift-ci Please smoke benchmark |
jckarter
reviewed
Sep 18, 2017
| Builtin.bridgeToRawPointer(Builtin.castToUnknownObject(l)), | ||
| Builtin.bridgeToRawPointer(Builtin.castToUnknownObject(r)) | ||
| )) | ||
| return ObjectIdentifier(l) == ObjectIdentifier(r) |
There was a problem hiding this comment.
@eeckstein @atrick Is the casting sequence here necessary for the optimizer to recognize === operations?
Build comment file:Optimized (O)Regression (3)
Improvement (1)
No Changes (323)
Unoptimized (Onone)Improvement (3)
No Changes (324)
Hardware Overview |
|
Interesting. We might be able to remove the type altogether, and just keep the TypeInfo in IRGen, used for lowering AnyObject and @objc class references. |
|
That's my SR-5926 hope! |
|
Still hoping for someone from @eeckstein's team to tell me whether this is okay, just in case. |
|
Since there are no regressions on the benchmarks, I think it's ok. |
|
I experimented with it. The new |
|
Thanks, both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the Swift level, this is equivalent to AnyObject, which we've done much more testing of. This commit paves the way for taking UnknownObject out of the SIL type system and just using it as type metadata. Filed SR-5926 to track that work.