-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Eradicate IndexDistance associated type #12641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Eradicate IndexDistance associated type #12641
Conversation
@swift-ci please test source compatibility |
@swift-ci please smoke test compiler performance |
Eagerly awaiting these results :) |
gah, the compatibility suite requires the tests to all build before it runs... |
Build comment file:Compilation-performance test failed |
@swift-ci please smoke test compiler performance |
@swift-ci please test source compatibility |
Build comment file:Compilation-performance test failed |
eefb8bc
to
0fcd4c2
Compare
OK finally fixed StdLibUnitTests, let's see if this works. |
@swift-ci please test source compatibility |
@swift-ci please smoke test compiler performance |
Where by fixed, I mean they compile... they still fail. |
@swift-ci please test source compatibility |
@swift-ci please smoke test compiler performance |
Build comment file:Compilation-performance test failed |
Please test with following pull request: @swift-ci please smoke test compiler performance |
Please test with following pull request: @swift-ci please test source compatibility |
Build comment file:Compilation-performance test failed |
OK migrated some SwiftPM stuff off of |
@swift-ci please test source compatibility |
@swift-ci please smoke test compiler performance |
@swift-ci please test compiler performance |
1 similar comment
@swift-ci please test compiler performance |
0fcd4c2
to
62b750c
Compare
@swift-ci please smoke benchmark |
@swift-ci please smoke test compiler performance |
Build comment file:Optimized (O)Regression (13)
Improvement (21)
No Changes (300)
Unoptimized (Onone)Regression (13)
Improvement (25)
No Changes (296)
Hardware Overview
|
Huh. Failure seems unrelated, lets try again. |
@swift-ci please test |
Build failed |
Build failed |
FYI, #13246 addresses the crash I was seeing with attempts to use |
Scratch that. #13250 is a more-appropriate fix for the deprecated |
32d43e9
to
b73e728
Compare
@swift-ci please test |
Build failed |
Build failed |
b73e728
to
9cb78da
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
Build failed |
Build failed |
@swift-ci please test linux platform |
@swift-ci please test source compatibility |
* Eradicate IndexDistance associated type, replacing with Int everywhere * Consistently use Int for ExistentialCollection’s IndexDistance type. * Fix test for IndexDistance removal * Remove a handful of no-longer-needed explicit types * Add compatibility shims for non-Int index distances * Test compatibility shim * Move IndexDistance typealias into the Collection protocol
* Eradicate IndexDistance associated type, replacing with Int everywhere * Consistently use Int for ExistentialCollection’s IndexDistance type. * Fix test for IndexDistance removal * Remove a handful of no-longer-needed explicit types * Add compatibility shims for non-Int index distances * Test compatibility shim * Move IndexDistance typealias into the Collection protocol
Implementation of [SE-0191]](https://github.com/apple/swift-evolution/blob/master/proposals/0191-eliminate-indexdistance.md).
Replaces all references to
IndexDistance
withInt
, and convertsAnyCollection
(the one type that usedInt64
).