utils: add -lswiftImageInspectionShared to static-executable-args.lnk #14929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the -static-executable part of the problem reported in SR-7038 (rdar://problem/37710244).
|
This is sufficient to link a "hello" program with -static-executable. The result runs. I don't know if this is really correct, though. |
|
@swift-ci please test |
compnerd
approved these changes
Mar 2, 2018
|
This actually is currently correct. The problem is that the ImageInspectionELF content is removed from the runtime which requires that we do this horrible thing. I think that the ship has sailed on the 4.1 release sadly. We can fix this properly in 5.0 by merging this back into the runtime and avoiding the secondary library. |
|
Build failed |
|
@swift-ci Please smoke test OS X platform |
This was referenced Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the -static-executable part of the problem reported in
SR-7038 (rdar://problem/37710244).