Optimize Documentation Images to Save Bandwidth #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit optimizes the images available in the docs folder in order to save on bandwidth and also decrease page loading time. Images updated: - docs/Array.png - docs/ArrayBridge.png - docs/ArrayCast.png - docs/ArrayImplementation.png - docs/ContiguousArray.png - docs/Slice.png
|
What is the actual win of doing this compression? How much space is saved? Note that doing this change actually increases the size of the cloned repository. |
|
@krememek This increases the git repository size overall but it will decrease the amount of bandwidth required to serve the Swift Documentation website. Since there are more people viewing the documentation than cloning the repository I believe there is a benefit. The reported size decrease is here, per file: |
|
@daknob 👍 200kb saved per doc user vs 564kb cost for clones. Worth it. |
|
Where in the swift.org site is this documentation? I could not find. |
tkremenek
added a commit
that referenced
this pull request
Feb 3, 2016
Optimize Documentation Images to Save Bandwidth
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Fix numbering in project goals
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Dec 19, 2018
Add support for typealias
kateinoigakukun
pushed a commit
to kateinoigakukun/swift
that referenced
this pull request
Feb 18, 2020
This allows installing build dependencies without actually building anything.
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Remove isExpr etc. methods
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Update ReactiveCocoa xfails with correct jira reference
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Jun 28, 2023
On recent main, this test case fails verification with ``` SIL memory lifetime failure in @$s4main4doityyF: memory is not initialized, but should be memory location: %21 = struct_element_addr %20 : $*M4, #M4.s2 // user: %23 at instruction: %23 = apply %22(%19, %21) : $@convention(thin) (@inout S, @inout S) -> () [...] 4. While running pass swiftlang#173 SILFunctionTransform "MoveOnlyChecker" on SILFunction "@$s4main4doityyF". for 'doit()' (at test/Interpreter/moveonly_reinit_noncontiguous.swift:32:1) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit optimizes the images available in the
docs folder in order to save on bandwidth and
also decrease page loading time.
Images updated: