[stdlib] Revert count(where:) #22289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
/cc @khanlou - sorry about this, will keep you updated on what we find and when we can restore |
|
Ah, this is a shame — let me know if there's anything I can do to help! |
2 tasks
|
I'd be interested to know why this happens for |
|
I am sure that performance is degraded for first and and count, we just didn’t yet observe it in practice probably because they are used less in conjunction with operators... |
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
May 7, 2019
- Fix `stdlib/public/TensorFlow/CMakeLists.txt`.
- List `ExecuteOp.swift.gyb` under GYB_SOURCES.
- Replace `count(where:)` with `lazy.filter { ... }.count`.
- `count(where:)` reverted in swiftlang#22289.
- Fix `ProtocolDecl::computeKnownProtocolKind()`.
- Update `test/TensorFlow/sema_errors.swift`.
- Unfortunately, diagnostics have regressed.
pschuh
pushed a commit
that referenced
this pull request
May 7, 2019
- Fix `stdlib/public/TensorFlow/CMakeLists.txt`.
- List `ExecuteOp.swift.gyb` under GYB_SOURCES.
- Replace `count(where:)` with `lazy.filter { ... }.count`.
- `count(where:)` reverted in #22289.
- Fix `ProtocolDecl::computeKnownProtocolKind()`.
- Update `test/TensorFlow/sema_errors.swift`.
- Unfortunately, diagnostics have regressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing performance problems in the type checker currently, due to conflicts with
Collection.count. Temporarily reverting until we can resolve the issue.