[TypeChecker] Improve contextual mismatch diagnostics for key path #24308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Detect situations where key path doesn't have capability required
by the context e.g. read-only vs. writable, or either root or value
types are incorrect e.g.
```swift
struct S { let foo: Int }
let _: WritableKeyPath<S, Int> = \.foo
```
Here context requires a writable key path but `foo` property is
read-only.
xedin
force-pushed
the
improve-contextual-diags-for-keypath
branch
from
2fa85d1 to
94977ee
Compare
|
/cc @brentdax |
|
@swift-ci please test |
DougGregor
approved these changes
Apr 26, 2019
beccadax
reviewed
Apr 26, 2019
| let _: ReferenceWritableKeyPath<A, Prop> = \.property | ||
| //expected-error@-1 {{cannot convert value of type 'WritableKeyPath<A, Prop>' to specified type 'ReferenceWritableKeyPath<A, Prop>'}} |
There was a problem hiding this comment.
Most of this test file puts the assertions on the same line or the line before; I think putting these on the line after might confuse future maintainers.
(This applies to the other changes in this file, too.)
There was a problem hiding this comment.
I don't think it's going to be a big problem especially considering that most of the tests (if not all) have expected checks on the same or line after the one checked. These TODOs where more of an exception to the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect situations where key path doesn't have capability required
by a context e.g. read-only vs. writable, or either root or value
types are incorrect e.g.
Here context requires a writable key path but
fooproperty isread-only.