Skip to content

Fix validation-test/SIL/verify_all_overlays.py on macOS. #24640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019

Conversation

dan-zheng
Copy link
Contributor

This test was originally XFAIL on macOS, but now passes since it's been disabled.
Re-enable XFAIL as part of TF-491.

This test was originally XFAIL on macOS, but now passes since it's been
disabled. Re-enable XFAIL as part of TF-491.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label May 9, 2019
@dan-zheng dan-zheng requested a review from marcrasi May 9, 2019 17:34
@dan-zheng
Copy link
Contributor Author

Running CI is not meaningful because macOS CI is temporarily broken (doesn't get past stdlib compilation).
Verified locally that there's only one remaining macOS test failure.

@dan-zheng dan-zheng merged commit edb7a39 into swiftlang:tensorflow-merge May 9, 2019
@dan-zheng dan-zheng deleted the tensorflow-merge branch May 9, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants