Skip to content

Changing the hyperlink word in README.md from 'the website' to 'Swift.org' #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

KrishMunot
Copy link
Contributor

Changing the hyperlink word in README.md from 'the website' to 'Swift.org'

Changing the hyperlink word in README.md from 'the website' to 'Swift.org'
@Undo1
Copy link
Contributor

Undo1 commented Dec 6, 2015

Looks a little weird to see capitalized website URLs - perhaps it'd be better as 'swift.org'? I do agree that 'the website' isn't the best way to word it.

@153957
Copy link

153957 commented Dec 6, 2015

The capitalisation is indeed a bit strange.
Moreover, making the text say 'swift.org' while linking to a subpage might be misleading.
I would argue to make the link text more descriptive, for example:

For more, see [code of conduct](https://swift.org/community/#code-of-conduct) on swift.org.

@KrishMunot
Copy link
Contributor Author

If you did refer the contributions guidelines and the other Swift.org sections, you will notice that Swift.org is capitalized with an 'S'. And this is expected to be followed throughout.
However, we can discuss more in detail about the second part of your comment with the authors here.

@jrose-apple
Copy link
Contributor

I think I agree with @153957: the [code of conduct]() on Swift.org sounds best to me.

(The capitalization is consistent with what's on the site itself.)

@KrishMunot
Copy link
Contributor Author

That's great! I made another PR and please check that if its alright. :)
Also thanks @153957 and @jrose-apple for the excellent suggestions.

@KrishMunot KrishMunot closed this Dec 8, 2015
dabelknap added a commit to dabelknap/swift that referenced this pull request Jun 26, 2019
Fix false diagnostics in BlankLinesBetweenMembers.
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants