Skip to content

Update build-script and CMake to support the Xcode CI bot again #26705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update build-script and CMake to support the Xcode CI bot again #26705

wants to merge 3 commits into from
+56 −33

Conversation

jrose-apple
Copy link
Contributor

Trying to get https://ci.swift.org/job/oss-swift-incremental-RA-macOS-xcode/ back online. We shut it down because it was flaky, but I haven't been able to reproduce the flakiness with the Xcode 11 betas, so maybe it's time to turn it back on. It's bit-rotted in the meantime, though, so these few commits get it working again (at least for building Swift itself).

Requires apple/swift-llvm#165.

@jrose-apple
Copy link
Contributor Author

preset=buildbot_incremental,tools=RA,stdlib=RA,xcode
@swift-ci Please test with preset macOS

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

Ugh, I did that wrong.

apple/swift-llvm#165
preset=buildbot_incremental,tools=RA,stdlib=RA,xcode
@swift-ci Please test with preset macOS

@jrose-apple
Copy link
Contributor Author 

16:22:47 CMake Error at /Applications/CMake.app/Contents/share/cmake-3.10/Modules/CMakeTestCXXCompiler.cmake:45 (message):
16:22:47   The C++ compiler
16:22:47 
16:22:47     "/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++"
16:22:47 
16:22:47   is not able to compile a simple test program.
16:22:47 
16:22:47   It fails with the following output:
16:22:47 
16:22:47     Change Dir: /Users/buildnode/jenkins/workspace/swift-PR-osx-preset/branch-master/buildbot_incremental_xcode/cmark-macosx-x86_64/CMakeFiles/CMakeTmp
16:22:47     
16:22:47     Run Build Command:"/usr/bin/xcodebuild" "-project" "CMAKE_TRY_COMPILE.xcodeproj" "build" "-target" "cmTC_1ade2" "-configuration" "Debug"
16:22:47     Build settings from command line:
16:22:47         TOOLCHAINS = default
16:22:47     
16:22:47     note: Using new build system
16:22:47     2019-08-16 16:22:47.259 xcodebuild[38588:7814060] unable to create build operation: Error Domain=com.apple.xcbuild Code=1 "unknown error while handling message: missingTarget(guid: "7aed596d5266adafa85154c51d08aed95ed0a5032aa072cdbba312f930621432")" UserInfo={NSLocalizedDescription=unknown error while handling message: missingTarget(guid: "7aed596d5266adafa85154c51d08aed95ed0a5032aa072cdbba312f930621432")}

Welp. Something up with the version of CMake on the bots?

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2eae9dc047d4baf883af4265419ece8569b45917

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2eae9dc047d4baf883af4265419ece8569b45917

@jrose-apple
build-script-impl: Use build_directory_bin for any build products
b08a01f 
These can be config-specific when building using Xcode. I probably
still missed a few, but this is enough to build and test Swift, at
least. Should be no change for Ninja users.
@jrose-apple
[CMake] Force the output dir of the fake-for-testing libBlocksRuntime
bbfda2e 
LLVM was setting config-specific paths that overrode the ones provided
here. We don't actually care about configuration for this dummy,
testing-only library, so just force it back to a flat layout based on
target platform.

No functionality change for Ninja users.
@jrose-apple
build-presets: Update/simplify incremental Xcode preset
2c069c4 
This is our /only/ standard Xcode preset, and it's been disabled for a
long time. Since only a limited configuration is supported for
building with Xcode (pretty much just LLVM and Swift, with only a
macOS standard library), it doesn't make sense to base it on the
regular incremental preset. Pare it down to what's most important to
keep working in hopes of turning the bot back on.
@jrose-apple
Copy link
Contributor Author

apple/swift-llvm#165
preset=buildbot_incremental,tools=RA,stdlib=RA,xcode
@swift-ci Please test with preset macOS

@jrose-apple
Copy link
Contributor Author

Maybe I can't fool the preset testing into doing an Xcode test. @shahmishal?

@swift-ci Please smoke test

@jrose-apple jrose-apple requested review from clackary and removed request for Rostepher October 11, 2019 01:46
@shahmishal
Copy link
Member 

17:24:15     note: Using new build system
17:24:15     2019-10-09 17:24:15.200 xcodebuild[89860:452780] unable to create build operation: Error Domain=com.apple.xcbuild Code=1 "unknown error while handling message: missingTarget(guid: "7aed596d5266adafa85154c51d08aed97cfc05b0301a04ed1571b57e637d2bd2")" UserInfo={NSLocalizedDescription=unknown error while handling message: missingTarget(guid: "7aed596d5266adafa85154c51d08aed97cfc05b0301a04ed1571b57e637d2bd2")}
17:24:15

@jrose-apple
Copy link
Contributor Author

jrose-apple commented Oct 14, 2019 •
edited
Loading

Yeah, I saw that error, and it is meaningless to me. Unless our CMake install is too old on these bots? Which seems unlikely.

@shahmishal
Copy link
Member

apple/swift-llvm#165
preset=buildbot_incremental,tools=RA,stdlib=RA,xcode
@swift-ci Please test with preset macOS

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@shahmishal shahmishal closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal

@clackary clackary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrose-apple @swift-ci @shahmishal