Requestify getInterfaceType() in Name Only #27314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make getInterfaceType() call validateDecl on behalf of its clients. In effect, this makes the interface type behave like a request. It also means that its clients no longer need to perform a number of undesirable anti-patterns in order to sidestep the bizarre API contract validateDecl has at the moment In particular, the following things are no longer necessary: - Checking for a missing interface type then validating - Validating the interface type then retrieving it - Validating the interface type then retrieving a derived value These anti-patterns will be removed in follow-up commits
|
@swift-ci please smoke test |
CodaFi
force-pushed
the
an-interface-to-the-interface
branch
from
6a23435 to
1233cdf
Compare
|
@swift-ci please smoke test |
slavapestov
reviewed
Sep 24, 2019
| // fact that they can't pull an interface type out to avoid doing work. | ||
| // This is a necessary evil until we can wean them off. | ||
| if (auto resolver = getASTContext().getLazyResolver()) | ||
| resolver->resolveDeclSignature(const_cast<ValueDecl *>(this)); |
There was a problem hiding this comment.
We still need the assert after this call I think.
slavapestov
reviewed
Sep 24, 2019
| @@ -3241,7 +3247,7 @@ Type TypeDecl::getDeclaredInterfaceType() const { | |||
| selfTy, const_cast<AssociatedTypeDecl *>(ATD)); | |||
| } | |||
|
|
|||
| Type interfaceType = hasInterfaceType() ? getInterfaceType() : nullptr; | |||
| Type interfaceType = getInterfaceType(); | |||
| if (interfaceType.isNull() || interfaceType->is<ErrorType>()) | |||
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please test source compatibility |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make getInterfaceType() call validateDecl on behalf of its clients. In effect, this makes the interface type behave like a request. It also means that its clients no longer need to perform a number of undesirable anti-patterns in order to sidestep the bizarre API contract validateDecl has at the moment
In particular, the following things are no longer necessary:
This patchset is a purely mechanical translation to the new API. There are an enormous number of places that no longer/never need to retrieve the interface type. I have tried my best to mark them off, but this patch does not go out of its way to fix them because it's already big enough as it is.
There is also one remaining use of
validateDeclfor VarDecls because that triggers a ton of extra side-effects that we need to untangle first.