[WIP] Refactor function builders to rewriting statements #27713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
function-builders-generalization
branch
from
06817af to
9d18cc7
Compare
DougGregor
changed the title
|
This is incomplete, because it doesn't handle function builders being applied to functions/properties. However, this is the intended direction, and I'd like to get some review on the general structure. |
…ons. The constraint system's support for function builders was limited to closure expressions. Generalize this support to work with arbitrary functions, as a precursor to handling application of function builders to functions via the same mechanism.
Handles the case of, e.g., `@ViewBuilder var body: some View { ... }`.
|
Everything here has been subsumed by #29133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the implementation of function builders so they maintain the statement structure of the closure/function body to which they are applied. This replaces the previous "fold everything into a single expression" implementation with one that is better in several regards:
buildBlock/buildExpression/buildIf/etc. invocation. The result is easier to reason about.if let, although each of these will require work.