[sil] Add a run of ownership model eliminator in the lowering pass pi… #27866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
…peline to ensure we eliminate ownership even if a bisecting counter has disabled the normal ome run. I also had to fix up one test and eliminated a test that did not really make sense in the first place to test with ossa. (Specifically, copy_value_destroy_value is a test I added when adding copy_value, destroy_value, it really doesn't make sense since we will just lower it to retain, release before we hit IRGen).
gottesmm
force-pushed
the
pr-501bcdba55c3d80c1684a9c3786e1b2b77b9f65b
branch
from
752c65d to
451252d
Compare
|
@swift-ci smoke test |
|
weird lldb error. I am going to actually do a full test of this. |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test linux platform |
|
More weird lldbness. |
|
All of the tests pass on os x. Just failed in lldb. |
|
@swift-ci smoke test os x platform |
|
again the lldb test failure. The lldb test failure was fixed in: |
|
@swift-ci smoke test os x platform |
|
@atrick SGTM |
1 similar comment
|
@atrick SGTM |
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
Nov 5, 2019
The test was deleted upstream in swiftlang#27866.
dan-zheng
added a commit
that referenced
this pull request
Nov 5, 2019
* Disable expected SILOptimizer test failures. These tests fail because `-enable-ownership-stripping-after-serialization` has been disabled for libswiftCore on tensorflow branch due to SR-11336. TF-799 tracks re-enabling these tests. * Fix libInMemoryFrontend unittests. * Remove test/IRGen/copy_value_destroy_value.sil. The test was deleted upstream in #27866.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…peline to ensure we eliminate ownership even if a bisecting counter has disabled the normal ome run.
Just ran into this while trying to bisect.