[Diagnostics] Refactor DiagnosticConsumer interface to remove unnecessary params #27868
Conversation
|
cc @jrose-apple , do you mind taking a quick look at these changes? It looks like you're the original author of the unit tests. |
DiagnosticInfo now holds all the information needed to consume a diagnostic, so remove unneeded parameters from handleDiagnostic.
owenv
force-pushed
the
diag-info-refactor
branch
from
03fbd0c to
8a67117
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Looks like I need to update swift-lldb as well, I'll put together a PR |
|
@jrose-apple assuming I understand the new monorepo branch setup correctly, this should build now with swiftlang/llvm-project#58 |
|
swiftlang/llvm-project#58 |
|
Build failed |
|
swiftlang/llvm-project#58 |
|
This may have caused a regression on the Windows build: https://ci-external.swift.org/job/oss-swift-windows-x86_64/1790/console |
|
@compnerd yeah, this was a silly mistake on my part. I think @drodriguez's fix should work |
DiagnosticInfonow holds all the information needed to consume a diagnostic, so remove unneeded parameters fromhandleDiagnostic.I've been meaning to clean this up for a while, it should make future changes a lot easier. I made sure everything builds and the unit tests pass, but there's always a chance I missed a consumer somewhere in one of the tools.