Skip to content

Fix macOS toolchains with Xcode new build system. #28945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

dan-zheng
Copy link
Contributor

Xcode's new build system requires the Version entry in Info.plist to have a
particular date-based format.

Resolves tensorflow/swift#350:

2019-12-24 15:47:16.618 XCBBuildService[75398:12495542] /Library/Developer/Toolchains/swift-tensorflow-DEVELOPMENT-2019-12-12-a.xctoolchain: warning: failed to load toolchain: 'Version' parse error: Could not parse version component from: 'swift-tensorflow-DEVELOPMENT-2019-12-12-a'

Swift for TensorFlow macOS toolchain working with Xcode new build system:
image

Xcode's new build system requires the `Version` entry in Info.plist to have a
particular date-based format.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Dec 24, 2019
@dan-zheng dan-zheng requested a review from compnerd December 24, 2019 20:55
@dan-zheng
Copy link
Contributor Author

This issue also exists in the upstream utils/build-toolchain script. We should submit a patch upstream as well.

On the forums, someone discovered this issue in utils/build-toolchain but didn't submit a fix.

@dan-zheng
Copy link
Contributor Author

Running CI is not meaningful because utils/build-toolchain-tensorflow is untested.

Verified that newly built macOS toolchains work with Xcode new build system: tensorflow/swift#349

@dan-zheng dan-zheng merged commit 96d4208 into swiftlang:tensorflow Dec 24, 2019
@dan-zheng dan-zheng deleted the macosx-toolchain-fix branch December 24, 2019 21:48
@RahulBhalley
Copy link

Does that mean we can build, run, and debug (as shown in Manifesto GIF) in Xcode itself now instead of running the program as swift main.swift?

@dan-zheng
Copy link
Contributor Author

dan-zheng commented Dec 25, 2019

Does that mean we can build, run, and debug (as shown in Manifesto GIF) in Xcode itself now instead of running the program as swift main.swift?

AutoDiff reverse debugging has actually always been possible (with Xcode's legacy build system) before this patch.

@RahulBhalley
Copy link

But I have never been able to run my S4TF program in Xcode although I could build them. And I can only run this with swift main.swift approach in terminal.

I have tried this solution with a fresh new Command Line Project but no success. I still have problem with this new swift-tensorflow-DEVELOPMENT-2019-12-23 toolchain.

@RahulBhalley
Copy link

Ok, so this worked for me. Thanks to Daisuke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants