Skip to content

NFC: Rename NameBinding to ImportResolution #30717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 30, 2020

Conversation

hamishknight
Copy link
Contributor

Now that it no longer deals with populating the operator lookup tables, it just does import resolution.

hamishknight and others added 5 commits March 29, 2020 18:43
This isn't used for anything.
A lot of places appear to mean "name lookup".  A few places meant "import resolution".
The directory currently seems to have a mix of
tests for import resolution and name lookup.
Therefore split it into two directories;
ImportResolution and NameLookup.
@hamishknight
Copy link
Contributor Author

swiftlang/llvm-project#996

@swift-ci please test

Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I’ll talk to David about getting a bunch of the swiftdeps tests into /Incremental which will further clean this up.

hamishknight added a commit to swiftlang/llvm-project that referenced this pull request Mar 30, 2020
@hamishknight hamishknight merged commit a460fb5 into swiftlang:master Mar 30, 2020
@hamishknight hamishknight deleted the not-legally-binding branch March 30, 2020 15:46
hamishknight added a commit to swiftlang/llvm-project that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants