[AutoDiff] Fix SR-12641: Handle address-only types in derivative fn types #31496
+144
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
approved these changes
May 2, 2020
I didn't do any exhaustive thinking while writing this PR, I just stumbled on these two cases by accident. So it's possible that there are some more holes somewhere. There is this inelegant diagnostic that simply rejects a lot of these cases: https://github.com/apple/swift/blob/a021e6ca020e667ce4bc8ee174e2de1cc0d9be73/include/swift/AST/DiagnosticsSIL.def#L500 |
|
@swift-ci please test |
|
Merging now to unblock progress. Edit: actually, unblocking progress isn't deathly urgent. I'm not sure whether you'd like to merge/squash commits, so I'll hold off. |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jun 3, 2020
…ypes (swiftlang#31496) * The update in `SILFunctionType.cpp` fixes SR-12641 by making address-only parameters/results in differentials have indirect convention. * I updated the crasher test to use a resilient struct defined in the test, instead of `Tracked<Float>`, so that the test does not need to depend on `DifferentiationUnittest`. * The update in `VJPEmitter.cpp` fixes a similar issue with pullbacks that I discovered while investigating. * I added code that exposes this new issue to the SR-12641 crasher test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILFunctionType.cppfixes SR-12641 by making address-only parameters/results in differentials have indirect convention.Tracked<Float>, so that the test does not need to depend onDifferentiationUnittest.VJPEmitter.cppfixes a similar issue with pullbacks that I discovered while investigating.