runtime: remove dependency on LLVM_ENABLE_THREADS
#31632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the LLVMSupport usage for thread local. This effectively is a no-op as the runtime requires that it is built with clang, which provides the C++11 `thread_local` support on all the targets. In the case that the target does not support `thread_local`, clang would fallback to `__declspec(thread)` on MSVC and `__thread` on other modes. However, because the runtime is always built in C++14 mode, the `thread_local` support should be assumed to be present. Remove the unnecessary condition and inline the single use of the macro for `thread_local`.
|
CC: @mikeash |
|
@swift-ci please test |
mikeash
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the LLVMSupport usage for thread local. This effectively
is a no-op as the runtime requires that it is built with clang, which
provides the C++11
thread_localsupport on all the targets. In thecase that the target does not support
thread_local, clang wouldfallback to
__declspec(thread)on MSVC and__threadon other modes.However, because the runtime is always built in C++14 mode, the
thread_localsupport should be assumed to be present. Remove theunnecessary condition and inline the single use of the macro for
thread_local.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.