Skip to content

Classify C++ structs as loadable or address-only #31707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2020
Merged

Classify C++ structs as loadable or address-only #31707

merged 4 commits into from
May 13, 2020

Conversation

MForster
Copy link
Contributor

C++ structs are only loadable if they are trivially copyable.

Resolves SR-12472.

@MForster MForster added the c++ interop Feature: Interoperability with C++ label May 11, 2020
@MForster MForster requested a review from gribozavr May 11, 2020 17:45
@MForster MForster self-assigned this May 11, 2020
@CodaFi
Copy link
Contributor

CodaFi commented May 11, 2020

This needs explicit initialization in StructDecl::StructDecl

@MForster
Copy link
Contributor Author

This needs explicit initialization in StructDecl::StructDecl

Done.

@MForster
Copy link
Contributor Author

@swift-ci Please test

@gribozavr
Copy link
Contributor

@swift-ci Please test macOS

@gribozavr
Copy link
Contributor

@swift-ci Please test Windows

@swiftlang swiftlang deleted a comment from swift-ci May 12, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 12, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 12, 2020
@shahmishal
Copy link
Member

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@MForster
Classify C++ structs as loadable or address-only
be4fe72 
C++ structs are only loadable if they are trivially copyable.

Resolves SR-12472.
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@MForster
Copy link
Contributor Author

@swift-ci Please test

@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@swiftlang swiftlang deleted a comment from swift-ci May 13, 2020
@MForster MForster merged commit e69abeb into swiftlang:master May 13, 2020
@martinboehme martinboehme mentioned this pull request Jun 18, 2020
Merged
@MForster MForster deleted the m/loadable-types branch August 14, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinboehme martinboehme martinboehme left review comments

@gribozavr gribozavr gribozavr approved these changes

Assignees

@MForster MForster

Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MForster @CodaFi @gribozavr @shahmishal @martinboehme