[Sema] Forbid leaking implementation-only imported types in SPI decls #31744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
force-pushed
the
dont-leak-ioi-in-spi
branch
from
37644c8 to
08abc0d
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
@_spi(Secret) @_implementationOnly import Libmeans that the API andSecretSPI ofLibis imported for use in local implementation details and the dependency onLibis hidden from all clients. This PR fixes a flaw allowing types imported as implementation-only to be exposed in the SPI of the local module. This could lead to the compiler emitting an invalid .private.swiftinterface file that would use types in SPI signatures without the related import hidden from even internal clients.We are considering changing the meaning of such an import but for now let’s make sure to enforce the expected behavior in a consistent way.