-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Test C++ out-of-line operator functions #32081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a test to verify that C++ out-of-line operator functions are imported correctly.
@swift-ci Please test |
Could you add SILGen and IRGen tests for just one of the operators? |
Done. |
@swift-ci Please test |
1 similar comment
@swift-ci Please test |
@swift-ci Please test Windows |
@swift-ci Please test |
@MForster Please update the tests to pass with MSVC mangled names on Windows. |
@swift-ci Please test |
Build failed |
This is apparently required for the Mac tests.
Build failed |
@swift-ci Please test Windows Platform |
@MForster Hi Michael, the test:
fails on armv7 on this bot https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-device-non_executable/104 |
Sorry for the breakage. Reverting. |
The output on armv7 is
arm64 (coercion to i64 happens before that):
The quickest way to run these tests on different architectures if you have access to a mac OS X machine is to invoke the build script with
|
Thanks, Arnold. This is very helpful. I was able to fix armv7 before I saw your reply, but arm64 would have been another roundtrip! |
Add a test to verify that C++ out-of-line operator functions are imported correctly.
This is part of addressing SR-12748.