[stdlib][cmake] OpenBSD target requires -lpthread. #32176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like FreeBSD, OpenBSD needs -lpthread for a target link. This is necessary to get the swift-reflection-test to link and build correctly.
gribozavr
approved these changes
Jun 4, 2020
|
@swift-ci Please test |
|
Have you manage to build swift on ether FreeBSD or OpenBSD? |
|
Yes, but there are a few more changes to upstream and caveats before Swift builds on OpenBSD out of the box. |
|
@3405691582 that's awesome. Could you provide a instruction of building on FreeBSD? I could make a port for it, so it's easier for others. |
|
Let's avoid unrelated comments and notifications on the PR. Feel free to look through my commit history; I will document everything when things are more closer to being complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like FreeBSD, OpenBSD needs -lpthread for a target link. This is
necessary to get the swift-reflection-test to link and build correctly.