-
Notifications
You must be signed in to change notification settings - Fork 10.5k
stdlib: Place @_semantics prespecialization requirement target under correct constraints #32324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
605e653
to
048c975
Compare
…correct constraints
048c975
to
b0205fa
Compare
@atrick ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a straightforward fix, so I approved it. I have to admit, I don't understand how the issue was exposed or what would break in the old version. The resulting symbol name should be the same either way.
@atrick I should have linked the explanation, sorry. The issue was exposed because substitution maps have become part of the identity of a |
@swift-ci please smoke test |
OK thanks. Makes sense. This PR looks like it's just adding some test flags though: #31893 [silgen] Add an extra swift-version 5 run to initializer tests |
My bad, fixed the link. |
@swift-ci please smoke test |
subscript.read
requiresBound: Strideable, Bound.Stride: SignedInteger
.The substitution map refactor in #31895 revealed this with a crash. With a bit of guidance, I am happy to add a regression test for master too, if warranted.