[sil] Add an implementation of isIndirectResultOperand() onto ApplySite that returns false for partial_apply. #33112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te that returns false for partial_apply. Sometimes when working with the operands of an ApplySite, one needs to bail early if one has a full apply site and the operand is an indirect result argument. Sadly, there isn't any such API on ApplySite (it is only on FullApplySite), even though technically a partial_apply can be viewed as just not having any indirect result operands! That is what this patch implements. To implement this I added a simple useful method called: ``` Optional<FullApplySite> ApplySite::asFullApplySite() const ``` Seems like a useful thing to have for these sorts of cases.
|
@swift-ci smoke test |
|
I think this is pretty uncontroversial. |
atrick
reviewed
Jul 30, 2020
|
|
||
| namespace swift { | ||
|
|
||
| inline Optional<FullApplySite> ApplySite::asFullApplySite() const { |
There was a problem hiding this comment.
@gottesmm this new API is inconsistent with existing apply site type coercion which always returns an invalid apply site on failure. Adding another layer of Optional is extremely confusing. I don't think you need this API anyway, but it definitely should not change the return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when working with the operands of an ApplySite, one needs to bail
early if one has a full apply site and the operand is an indirect result
argument. Sadly, there isn't any such API on ApplySite (it is only on
FullApplySite), even though technically a partial_apply can be viewed as just
not having any indirect result operands! That is what this patch implements.
To implement this I added a simple useful method called:
Seems like a useful thing to have for these sorts of cases.