[cxx-interop] Bail instead of crashing If we cannot find a constructor decl in importNameImpl. #34429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r decl in importNameImpl. It's possible to have a "UnresolvedUsingValueDecl" with a "CXXConstructorName". If that's the case (or if there's any other unkown decl) bail instead of crashing.
zoecarver
requested review from
gribozavr,
martinboehme and
varungandhi-apple
|
To be honest, I'm not 100% sure this is the correct patch. It might be better to just add support for all possible decls with "CXXConstructorName". |
varungandhi-apple
approved these changes
Oct 30, 2020
|
As it is, I think this looks OK, but yeah, I'm not sure about the "It might be better to just add support for all possible decls with "CXXConstructorName". If that's something that's easy to do then sure. This also works as a stop-gap solution. |
That's mostly what this is. |
|
@swift-ci please smoke test and merge. |
|
@swift-ci please smoke test. |
|
Out of space error. @swift-ci please test Windows platform. |
|
Still out of space. @swift-ci please test Windows platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to have a "UnresolvedUsingValueDecl" with a "CXXConstructorName". If that's the case (or if there's any other unknown decl) bail instead of crashing.